Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched YUM repo to use the new CentOS Storage group repository #69

Merged
merged 3 commits into from
Oct 12, 2016
Merged

Switched YUM repo to use the new CentOS Storage group repository #69

merged 3 commits into from
Oct 12, 2016

Conversation

tux-o-matic
Copy link
Contributor

@tux-o-matic tux-o-matic commented Sep 6, 2016 •
edited
Loading

This is to fix the problem described in #63 and #68.
The GlusterFS community (and well RedHat) moved the responsibility of providing RPMs for EL systems to a new SIG group in the CentOS community.

Since the new CentOS repo has a slightly diferent structure than the GlusterFS repo used for systems using APT, I had to introduce a new parameter named "release" (explained in the README). This should be used on EL systems for running older GlusterFS versions and combined iwth the existing "version" parameter

While at it, I simplified the code handling the YUM repo and updated some parts of the documentation related to repos which were out dated.

The name of the Yumrepo resource remained the same in order to update its settings for systems already using this module. If installed by the CentOS rpm 'centos-release-gluster', the name of the repo configured on the system would differ repo

@tux-o-matic
Copy link
Contributor Author

We might want to work update the test case for unsupported architecture.
The Puppet code will raise an error when unsupported and the test scenario doesn't handle that nicely.

@tux-o-matic
Copy link
Contributor Author

@bastelfreak could you or any other community members look into this PR?
The module can no longer install GlusterFS on OS relaying on YUM to get the packages since the GlusterFS community moved the repo to CentOS managed servers.

@bastelfreak
Copy link
Member

Hi, in general the PR looks good. Can you take a look at the test for the architecture?

Corrected fail message to pass test
3bc3372 
Corrected message raised on unsupported architectures to pass test.
@tux-o-matic
Copy link
Contributor Author

tux-o-matic commented Oct 12, 2016 •
edited
Loading

Fixed. just took a little re-phrasing of the message in the error raised on unsupported architecture.

You might want to bump up the version number for the next release on Puppet Forge given that this PR introduces a change in the parameters for YUM based OSes.

@bastelfreak
Copy link
Member

Thanks!

@bastelfreak bastelfreak merged commit 56a9f13 into voxpupuli:master Oct 12, 2016
@bastelfreak bastelfreak mentioned this pull request Oct 12, 2016
Open
@tux-o-matic tux-o-matic deleted the fix_yumrepo branch October 12, 2016 11:09
@bastelfreak bastelfreak mentioned this pull request Oct 12, 2016
Closed
@tux-o-matic tux-o-matic mentioned this pull request Oct 21, 2016
Closed
cegeka-jenkins pushed a commit to cegeka/puppet-gluster that referenced this pull request Jul 20, 2018
@bastelfreak
Merge pull request voxpupuli#69 from tux-o-matic/fix_yumrepo
46b4bb4 
Switched YUM repo to use the new CentOS Storage group repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tux-o-matic @bastelfreak